Skip to content

Add CupertinoTimerPicker Interactive Example #93621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 7 commits into from
Jan 28, 2022
Merged

Add CupertinoTimerPicker Interactive Example #93621

fluttergithubbot merged 7 commits into from
Jan 28, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Nov 14, 2021 •
edited
Loading

This adds an official CupertinoTimerPicker example, this makes it much easier to try timer picker without navigating to large Flutter Gallery source code or relying on third-party websites.

Note:
I couldn't format the duration without importing intl.

Related #72926

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Nov 14, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 14, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 14, 2021
gspencergoog
gspencergoog reviewed Nov 15, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but will need a test.

@TahaTesser TahaTesser mentioned this pull request Nov 15, 2021
Closed
@TahaTesser
Copy link
Member Author

TahaTesser commented Nov 15, 2021

@gspencergoog
Added test and cleaned up
Thank you so much for the review!

gspencergoog
gspencergoog requested changes Nov 15, 2021
View reviewed changes
@Hixie
Copy link
Contributor

Hixie commented Jan 26, 2022

@TahaTesser Is this PR still on your radar?

@TahaTesser
Copy link
Member Author

TahaTesser commented Jan 26, 2022 •
edited
Loading

@Hixie
Yes. I have been favoring material doc issues lately since I have been working with Material widgets.
Thanks for the ping! I will update this and other Cupertino docs I have opened in a day.

@TahaTesser
Copy link
Member Author

TahaTesser commented Jan 26, 2022

@gspencergoog
Added comments similar to my other example (CupertinoDatepicker) and changed hms to hm so to showcase non-default parameters in the example, update example title as well. Sorry for the delay, thanks for the review!

gspencergoog
gspencergoog approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit fc71ec5 into flutter:master Jan 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2022
@engine-flutter-autoroll
fc71ec5 Add CupertinoTimerPicker Interactive Example (flutter/flutt…
f1c6226 
…er#93621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 28, 2022
Closed
@TahaTesser TahaTesser deleted the cupertino_timer_picker_example branch January 28, 2022 14:38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2022
@engine-flutter-autoroll
fc71ec5 Add CupertinoTimerPicker Interactive Example (flutter/flutt…
d5e5c11 
…er#93621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2022
@engine-flutter-autoroll
fc71ec5 Add CupertinoTimerPicker Interactive Example (flutter/flutt…
0336401 
…er#93621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2022
@engine-flutter-autoroll
fc71ec5 Add CupertinoTimerPicker Interactive Example (flutter/flutt…
5e07045 
…er#93621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2022
@engine-flutter-autoroll
fc71ec5 Add CupertinoTimerPicker Interactive Example (flutter/flutt…
0f836f6 
…er#93621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2022
@engine-flutter-autoroll
fc71ec5 Add CupertinoTimerPicker Interactive Example (flutter/flutt…
bd9d7c9 
…er#93621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
fc71ec5 Add CupertinoTimerPicker Interactive Example (flutter/flutt…
24b6e15 
…er#93621)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
Add CupertinoTimerPicker Interactive Example (flutter#93621)
683d1ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TahaTesser @Hixie @gspencergoog @fluttergithubbot