Skip to content

Conversation

@hrishikesh-kadam
Copy link
Contributor

This will help to generate coverage for the Package when running
Integration test on the Package's example like project.
For example,

$ cd my-package/example
$ flutter test integration_test --coverage --coverage-for-parent-package

Coverage will be stored at my-package/coverage/lcov.info.

List which issues are fixed by this PR. You must list at least one issue.

Use case Package repo - flutter_package_integration_testing_coverage

It would be appropriate that the Flutter Authors take this PR forward to achieve the above feature request.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This will help to generate coverage for the Package when running
Integration test on the Package's example like project.
For example,
```
$ cd my-package/example
$ flutter test integration_test --coverage --coverage-for-parent-package
```
Coverage will be stored at `my-package/coverage/lcov.info`.
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 14, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@hrishikesh-kadam
Copy link
Contributor Author

@jiahaog Requesting your review on this PR.

@christopherfujino christopherfujino self-requested a review January 13, 2022 22:19
@christopherfujino christopherfujino removed their request for review February 17, 2022 21:33
@christopherfujino
Copy link
Contributor

@jiahaog do you think this is the right change to make?

@christopherfujino
Copy link
Contributor

I'm sorry @hrishikesh-kadam, but I'm going to close this PR as I am not sure this is the correct approach. Feel free to discuss on your feature request: #93619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants