Skip to content

Added optional parameter keyboardType to showDatePicker #93439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darrenaustin merged 1 commit into from
Feb 22, 2022
Merged

Added optional parameter keyboardType to showDatePicker #93439

darrenaustin merged 1 commit into from
Feb 22, 2022

Conversation

@kirolous-nashaat
Copy link
Contributor

@kirolous-nashaat kirolous-nashaat commented Nov 10, 2021 •
edited
Loading

Added optional parameter keyboardType to showDatePicker to override the default TextInputType.datetime in input mode

Temporary fix for #62401

First PR so feel free to correct me :), Thanks to Flutter Boring show BTW 😄.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 10, 2021
@google-cla google-cla bot added the cla: no label Nov 10, 2021
@kirolous-nashaat kirolous-nashaat marked this pull request as ready for review November 10, 2021 23:40
@kirolous-nashaat
Copy link
Contributor Author

kirolous-nashaat commented Nov 10, 2021

I have signed the CLA but it still says No :/

@TodorGinchev
Copy link
Contributor

TodorGinchev commented Nov 15, 2021 •
edited
Loading

I have signed the CLA but it still says No :/

This happened to me as well because I signed it with one email but submitted the PR with another, check to make sure you did not do the same mistake :).

@kirolous-nashaat kirolous-nashaat marked this pull request as draft November 18, 2021 09:34
@kirolous-nashaat kirolous-nashaat marked this pull request as ready for review November 18, 2021 09:34
@kirolous-nashaat
Copy link
Contributor Author

kirolous-nashaat commented Nov 18, 2021

I have signed the CLA but it still says No :/

This happened to me as well because I signed it with one email but submitted the PR with another, check to make sure you did not do the same mistake :).

I just made sure of that, I think I need someone to rerun the cla check on the PR.

@kirolous-nashaat
Copy link
Contributor Author

kirolous-nashaat commented Nov 20, 2021

The CLA passed in another PR I created, Please re-run the CLA check on this PR, Thank you

@kirolous-nashaat
Copy link
Contributor Author

kirolous-nashaat commented Feb 3, 2022

@darrenaustin can you please look into this ?
Thank you.

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 22, 2022
darrenaustin
darrenaustin approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution! I have been meaning to do this for awhile so thank you.

flutter-lgtm

Piinks
Piinks approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@darrenaustin darrenaustin merged commit 9dc9cf5 into flutter:master Feb 22, 2022
justinmc
justinmc approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

packages/flutter/lib/src/material/input_date_picker_form_field.dart

/// The keyboard type of the [TextField].
///
/// If this is null, it will default to [TextInputType.datetime]
Copy link
Contributor

@justinmc justinmc Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This comment is the same as in date_picker.dart, so you could use a template and macro to reuse it (see autofocus just below this using a macro).

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
9dc9cf5 Added optional parameter keyboardType to showDatePicker (flut…
b801b6e 
…ter/flutter#93439)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
9dc9cf5 Added optional parameter keyboardType to showDatePicker (flut…
59497f6 
…ter/flutter#93439)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
9dc9cf5 Added optional parameter keyboardType to showDatePicker (flut…
651d6d0 
…ter/flutter#93439)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
9dc9cf5 Added optional parameter keyboardType to showDatePicker (flut…
106ebbf 
…ter/flutter#93439)
@zanderso zanderso mentioned this pull request Feb 27, 2022
Closed
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@kirolous-nashaat @clocksmith
Added optional parameter keyboardType to showDatePicker (flutter#93439)
cd41506
@kirolous-nashaat kirolous-nashaat deleted the fix_62401 branch March 23, 2022 10:36
@jgoyvaerts
Copy link
Contributor

jgoyvaerts commented Apr 29, 2022 •
edited
Loading

@justinmc what flutter version will this change be released with? I noticed it's not in one of the 2.11 candidates, however this PR is quite critical for our app

Edit: Nevermind found it in 2.12 and up

@ko16a46 ko16a46 mentioned this pull request Mar 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@Piinks Piinks Piinks approved these changes

+1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kirolous-nashaat @TodorGinchev @jgoyvaerts @darrenaustin @justinmc @Piinks