Skip to content

Update minimum required version to Xcode 12.3 #93094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Nov 5, 2021
Merged

Update minimum required version to Xcode 12.3 #93094

fluttergithubbot merged 1 commit into from
Nov 5, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 5, 2021 •
edited
Loading

Upgrade minimum Xcode version enforced by the tool to Xcode 12.3 (released December 2020), which contains the macOS Big Sur SDK needed to unblock #84453. Once users are on 12.3, the engine builders can be upgraded (but not before that, to avoid bitcode submission issues).

Fixes #93093

Previous Xcode bump at #77025.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@jmagman jmagman added the t: xcode "xcodebuild" on iOS and general Xcode project management label Nov 5, 2021
@jmagman jmagman self-assigned this Nov 5, 2021
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 5, 2021
@google-cla google-cla bot added the cla: yes label Nov 5, 2021
@jmagman jmagman mentioned this pull request Nov 5, 2021
Closed
jmagman
jmagman commented Nov 5, 2021
View reviewed changes
packages/flutter_tools/lib/src/macos/xcode.dart
/// Diverging this number from the minimum required version will provide a doctor
/// warning, not error, that users should upgrade Xcode.
Version get xcodeRecommendedVersion => Version(13, 0, 0, text: '13.0.0');
Version get xcodeRecommendedVersion => Version(13, null, null, text: '13');
Copy link
Member Author

@jmagman jmagman Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized this should have been 13, null, null so it gets printed as Xcode 13 and not Xcode 13.0.0.

@fluttergithubbot fluttergithubbot merged commit 31933af into flutter:master Nov 5, 2021
@jmagman jmagman deleted the xcode-12-3 branch November 5, 2021 23:08
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@jmagman @WizzXu
Update minimum required version to Xcode 12.3 (flutter#93094)
13dd384
@jmagman jmagman mentioned this pull request Dec 15, 2021
Merged
8 tasks
@jmagman jmagman added the platform-ios iOS applications specifically label Feb 18, 2022
@jmagman jmagman mentioned this pull request Apr 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

@jmagman jmagman

Labels

a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update tool minimum version to Xcode 12.3

3 participants

@jmagman @zanderso @fluttergithubbot