[TextInput] send setEditingState before show to the text input plugin when switching input clients
#92945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin when switching input clients - Fixes flutter#68571 Some Android keyboards ignore `showSoftInput` if they're immediately told to restart after the `showSoftInput`. - Related: flutter#41990
flutter-dashboard
bot
added
a: text input
Contributor
Author
mdebbar
approved these changes
Nov 9, 2021
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
On the web, we had issues with the order of messages a while ago. Since then, we changed our implementation to handle any order. So this should be good to go for web.
justinmc
approved these changes
Nov 19, 2021
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
This order seems reasonable to me, but I'm interested if Gary has any input.
GaryQian
approved these changes
Nov 23, 2021
Contributor
GaryQian
left a comment
GaryQian
left a comment
There was a problem hiding this comment.
LGTM.
This ordering change should be safe as later on, I was able to fix the root cause for the samusng issues and it was not related to this ordering.
LongCatIsLooong
deleted the
text-input-commands-setEditingState-before-show
branch
8 tasks
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Android keyboards ignore
showSoftInputif they're immediately told torestart after the
showSoftInput.Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.