Skip to content

Skip codesigning during native macOS integration tests #92938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
Nov 2, 2021
Merged

Skip codesigning during native macOS integration tests #92938

fluttergithubbot merged 4 commits into from
Nov 2, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 2, 2021 •
edited
Loading

@jmagman jmagman self-assigned this Nov 2, 2021
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Nov 2, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 2, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 2, 2021
@flutter-dashboard flutter-dashboard bot added the f: integration_test The flutter/packages/integration_test plugin label Nov 2, 2021
CaseyHillers
CaseyHillers approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jmagman
Copy link
Member Author

jmagman commented Nov 2, 2021 •
edited
Loading

The codesigning part worked, but the actual test being run failed:

[native_ui_tests_macos] [STDOUT] stdout: /opt/s/w/ir/x/w/recipe_cleanup/tmpZ3rybX/flutter sdk/dev/integration_tests/flutter_gallery/macos/RunnerTests/RunnerTests.m:21: error: -[RunnerTests testMenu] : (([mainMenu itemWithTitle:@"Edit"].submenu.numberOfItems) equal to (19)) failed: ("18") is not equal to ("19")
[native_ui_tests_macos] [STDOUT] stdout: Test Case '-[RunnerTests testMenu]' failed (0.073 seconds).

https://ci.chromium.org/p/flutter/builders/try/Mac%20native_ui_tests_macos/2

I can fix that.

keyonghan
keyonghan reviewed Nov 2, 2021
View reviewed changes
.ci.yaml

- name: Mac native_ui_tests_macos
recipe: devicelab/devicelab_drone
bringup: true
Copy link
Contributor

@keyonghan keyonghan Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest we validate the changes before enabled back in prod.

Copy link
Member Author

@jmagman jmagman Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will. I'm making sure it passes in presubmit since bringup:true is skipped, and then I will change it back.

@jmagman
Copy link
Member Author

jmagman commented Nov 2, 2021

It passed. https://ci.chromium.org/p/flutter/builders/try/Mac%20native_ui_tests_macos/3

@jmagman jmagman requested a review from cbracken November 2, 2021 22:41
keyonghan
keyonghan approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit dc20a60 into flutter:master Nov 2, 2021
@jmagman jmagman deleted the native_ui_tests_macos branch November 3, 2021 17:08
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@jmagman @WizzXu
Skip codesigning during native macOS integration tests (flutter#92938)
b512031
@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken Awaiting requested review from cbracken

2 more reviewers

@CaseyHillers CaseyHillers CaseyHillers approved these changes

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. f: integration_test The flutter/packages/integration_test plugin

Projects

None yet

Milestone

No milestone

4 participants

@jmagman @CaseyHillers @keyonghan @fluttergithubbot