Filter Android logs by the pid of the remote process #9293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
reviewed
Apr 7, 2017
Member
There was a problem hiding this comment.
Any reason not to make this read-write (i.e., just a field)?
Member
Author
There was a problem hiding this comment.
This was done in case subclasses needed to add side effects when the pid is set, but it looks like that's unnecessary. Moved this to a field in the superclass.
jason-simmons
force-pushed
the
log_stream_pid_filter
branch
from
01e3f6a to
508d9cf
Compare
cbracken
approved these changes
Apr 7, 2017
Member
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6849