Skip to content

[flutter_tools] Fix bundle file not found when flavor contains upperc… #92660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Feb 4, 2022
Merged

[flutter_tools] Fix bundle file not found when flavor contains upperc… #92660

fluttergithubbot merged 2 commits into from
Feb 4, 2022

Conversation

@MichaelTamm
Copy link
Contributor

@MichaelTamm MichaelTamm commented Oct 28, 2021

This PR fixes issue #91582

Pre-launch Checklist

  • [✓] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [✓] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [✓] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • [?] I signed the [CLA]. (I think, I signed a CLA once for another Google project)
  • [✓] I listed at least one issue that this PR fixes in the description above.
  • [✓] I updated/added relevant documentation (doc comments with ///).
  • [✓] I added new tests to check the change I am making.
  • [✓] All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 28, 2021
@google-cla google-cla bot added the cla: yes label Oct 28, 2021
This was referenced Oct 28, 2021
Closed
Closed
christopherfujino
christopherfujino reviewed Dec 2, 2021
View reviewed changes
@christopherfujino
Copy link
Contributor

christopherfujino commented Dec 2, 2021

Hey @MichaelTamm very sorry that I missed reviewing this. Taking a look now...

@christopherfujino
Copy link
Contributor

christopherfujino commented Dec 2, 2021

@untoldone could you also take a look at this PR?

@MichaelTamm
Copy link
Contributor Author

MichaelTamm commented Dec 10, 2021

ping

christopherfujino
christopherfujino approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix!

@christopherfujino
Copy link
Contributor

christopherfujino commented Jan 20, 2022

@MichaelTamm I believe your CI failure is due to the cirrus GCP token being out of date. Can you rebase upstream and see if the tests go green?

@MichaelTamm
Copy link
Contributor Author

MichaelTamm commented Jan 21, 2022

I rebased my fork on HEAD of flutter:master

@skia-gold
Copy link

skia-gold commented Jan 21, 2022

Gold has detected about 8 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/92660

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 3, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

jonahwilliams
jonahwilliams approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 1fcb076 into flutter:master Feb 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
f1165ae 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
43fa421 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
ad3cdf8 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
6e52af3 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
a4a4ddb 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
2adcd40 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
1341049 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
aaeeda6 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
9d4507c 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
9dde923 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
3908118 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
8c0b43e 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
02a81f5 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
69b924b 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
0e5e651 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
686e031 
…s upperc… (flutter/flutter#92660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
89a3435 
…s upperc… (flutter/flutter#92660)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
33d83f2 
…s upperc… (flutter/flutter#92660)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
20bede2 
…s upperc… (flutter/flutter#92660)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
3f0ebb2 
…s upperc… (flutter/flutter#92660)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1fcb076 [flutter_tools] Fix bundle file not found when flavor contain…
b26460c 
…s upperc… (flutter/flutter#92660)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@MichaelTamm @clocksmith
[flutter_tools] Fix bundle file not found when flavor contains upperc… (
ee01909 
flutter#92660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MichaelTamm @christopherfujino @skia-gold @fluttergithubbot @jonahwilliams