Skip to content

Conversation

@GaryQian
Copy link
Contributor

This roll is not meant to be landed and is meant to be used to see how the framework presubmit behaves with the v1 android embedding deleted.

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Oct 28, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Oct 28, 2021
@GaryQian
Copy link
Contributor Author

This will need flutter/plugins#4457 to remove the v1 embedding registerWith methods in plugins.

@GaryQian GaryQian marked this pull request as draft November 3, 2021 00:08
@Hixie
Copy link
Contributor

Hixie commented Jan 19, 2022

@GaryQian I'm going to close this one since it's not meant to be landed and presumably what you were doing with it is done by now. Please don't hesitate to reopen if I was wrong. :-)

@Hixie Hixie closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants