Remove assert that prevents WidgetSpans from being used in SelectableText#92295
Remove assert that prevents WidgetSpans from being used in SelectableText#92295fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks |
|
Very happy with this change finally being merged. Now I don't have to instruct this change made to developers working on my project. For the richer support when it comes to My current implementation for the tap widget is a I swap between a If a I remember a document being passed around for behavior suggestions on the clipboard behavior of a |
|
@lrorpilla Thanks for the ideas here. I've created a new issue for copying WidgetSpans: #92506. This has been on my mind but I guess we didn't have an issue for it until now. We also have #23603, about rich text copy/paste, but I think that's slightly different. |
Partially resolves #38474
Manually removing this assert and using WidgetSpans seems to be stable in the wild. Since fully integrated selectable text/editable WidgetSpan support may take a significant effort but does not detract from simple use cases, we should remove this assert for now and gradually add richer support in as necessary. This unlocks WidgetSpan capability for anyone who does not need rich selection indexing and clipboards.
Tests coming soon.