Skip to content

Reland Remove BottomNavigationBarItem.title deprecation #92197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
Nov 15, 2021
Merged

Reland Remove BottomNavigationBarItem.title deprecation #92197

fluttergithubbot merged 5 commits into from
Nov 15, 2021

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Oct 20, 2021

Re-lands original PR #90295, reverted in #91930

This removes the title parameter from BottomNavigationBarItem.

The replacement for which is to use label instead. This is supported by dart fix.

This deprecations has expired, as laid out in flutter.dev/go/deprecations-removed-after-2-5

Part of #90287

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 20, 2021
@google-cla google-cla bot added the cla: yes label Oct 20, 2021
@Piinks Piinks requested a review from goderbauer October 20, 2021 17:51
goderbauer
goderbauer approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 0a2227c into flutter:master Nov 15, 2021
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@Piinks @WizzXu
Reland Remove BottomNavigationBarItem.title deprecation (flutter#92197)
186f0c7
@SimonVillage SimonVillage mentioned this pull request Feb 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @goderbauer @fluttergithubbot