Skip to content

rename initWithFlutterView to initWithController #9208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
collinjackson merged 1 commit into from
Apr 5, 2017
Merged

rename initWithFlutterView to initWithController #9208

collinjackson merged 1 commit into from
Apr 5, 2017

Conversation

@collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Apr 5, 2017

No description provided.

jakobr-google
jakobr-google approved these changes Apr 5, 2017
View reviewed changes
Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@collinjackson collinjackson merged commit 244a7a0 into flutter:master Apr 5, 2017
@collinjackson collinjackson deleted the initWithController branch April 5, 2017 15:21
@liyuqian liyuqian mentioned this pull request Jun 6, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

+1 more reviewer

@jakobr-google jakobr-google jakobr-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@collinjackson @chinmaygarde @jakobr-google @googlebot