Skip to content

Revert "Remove BottomNavigationBarItem.title deprecation" #91930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Oct 16, 2021
Merged

Revert "Remove BottomNavigationBarItem.title deprecation" #91930

fluttergithubbot merged 1 commit into from
Oct 16, 2021

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Oct 15, 2021

Reverts #90295

There are some affected customers. Reverting to migrate them first.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 15, 2021
@google-cla google-cla bot added the cla: yes label Oct 15, 2021
dkwingsmt
dkwingsmt approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@fluttergithubbot fluttergithubbot merged commit 9608a64 into master Oct 16, 2021
@fluttergithubbot fluttergithubbot deleted the revert-90295-bottomnav branch October 16, 2021 10:36
@Piinks Piinks mentioned this pull request Oct 20, 2021
Merged
8 tasks
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@Piinks @clocksmith
Revert "Remove BottomNavigationBarItem.title deprecation" (flutter#91930
35c5c55 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @dkwingsmt @fluttergithubbot