Skip to content

[ReorderableListView] Update doc with example to make it clear proxyDecorator can be overriden to customise an item when it is being dragged.#91837

Merged
darrenaustin merged 6 commits intoflutter:masterfrom
TahaTesser:proxy_decorator_doc
Nov 4, 2021
Merged

[ReorderableListView] Update doc with example to make it clear proxyDecorator can be overriden to customise an item when it is being dragged.#91837
darrenaustin merged 6 commits intoflutter:masterfrom
TahaTesser:proxy_decorator_doc

Conversation

@TahaTesser
Copy link
Copy Markdown
Contributor

@TahaTesser TahaTesser commented Oct 14, 2021 •
edited
Loading

I was looking to add this "new feature" #45799
Turns out, it is already possible to add a custom background when it is being dragged by overriding default proxyDecorator

This fixes #45799

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 14, 2021
@flutter-dashboard
Copy link
Copy Markdown

flutter-dashboard bot commented Oct 14, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Oct 14, 2021
@goderbauer
Copy link
Copy Markdown
Member

goderbauer commented Oct 14, 2021

Fly-by comment: Looks like the doc checker is not happy.

@TahaTesser TahaTesser changed the title [ReorderableListView] Add code snippet to make it clear proxyDecorator can overriden to customise an item when it is being dragged. [ReorderableListView] Update doc with example to make it clear proxyDecorator can overriden to customise an item when it is being dragged. Oct 16, 2021
@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Oct 16, 2021
@TahaTesser TahaTesser requested a review from HansMuller October 19, 2021 08:48
HansMuller
HansMuller reviewed Nov 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example! Just a few suggested tweaks.

darrenaustin
darrenaustin suggested changes Nov 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this @TahaTesser. I echo Hans' comments and suggestions below. Once those are addressed, I think this will be good to go.

@TahaTesser TahaTesser requested a review from HansMuller November 3, 2021 19:49
HansMuller
HansMuller reviewed Nov 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more fixup is needed....

@TahaTesser TahaTesser removed the request for review from darrenaustin November 3, 2021 22:43
@TahaTesser
Copy link
Copy Markdown
Contributor Author

TahaTesser commented Nov 3, 2021 •
edited
Loading

@HansMuller
This looks good to go, thanks for resource link I will keep in mind for future PRs

HansMuller
HansMuller approved these changes Nov 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Copy Markdown
Contributor

fluttergithubbot commented Nov 4, 2021

This pull request is not suitable for automatic merging in its current state.

  • This pull request has changes requested by @darrenaustin. Please resolve those before re-applying the label.

darrenaustin
darrenaustin approved these changes Nov 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx!

@darrenaustin darrenaustin merged commit 6fc9881 into flutter:master Nov 4, 2021
@TahaTesser TahaTesser deleted the proxy_decorator_doc branch November 4, 2021 07:15
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@TahaTesser @WizzXu
[ReorderableListView] Update doc with example to make it clear `proxy…
2d4fbbc 
…Decorator` can overriden to customise an item when it is being dragged. (flutter#91837)
@bleroux bleroux changed the title [ReorderableListView] Update doc with example to make it clear proxyDecorator can overriden to customise an item when it is being dragged. [ReorderableListView] Update doc with example to make it clear proxyDecorator can be overriden to customise an item when it is being dragged. Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@darrenaustin darrenaustin darrenaustin approved these changes

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reorderable List View – Dragging Background Color

5 participants

@TahaTesser @goderbauer @fluttergithubbot @darrenaustin @HansMuller