Skip to content

Conversation

@darrenaustin
Copy link
Contributor

Addresses most of the issues raised in #91587. Made sure all of the properties in the raw constructor, lerp, operator ==, and hashcode functions are the same and in the same order. Also added missing properties in the diagnostics and fixed some naming issues there as well.

Fixes #91587.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 13, 2021
@google-cla google-cla bot added the cla: yes label Oct 13, 2021
@darrenaustin darrenaustin mentioned this pull request Oct 14, 2021
8 tasks
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rydmike
Copy link
Contributor

rydmike commented Oct 14, 2021

Thanks, this looks good.

@darrenaustin darrenaustin merged commit ac745b3 into flutter:master Oct 14, 2021
@darrenaustin darrenaustin deleted the theme_data_issues branch October 14, 2021 22:14
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ThemeData issues with operator, copyWith and debugFillProperties

3 participants