Skip to content

Revert gradle roll #91459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
godofredoc merged 5 commits into from
Oct 8, 2021
Merged

Revert gradle roll #91459

godofredoc merged 5 commits into from
Oct 8, 2021

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Oct 8, 2021

The gradle roll broke many things.

@zanderso zanderso requested a review from godofredoc October 8, 2021 01:49
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 8, 2021
@google-cla google-cla bot added the cla: yes label Oct 8, 2021
@zanderso zanderso requested review from TahaTesser and blasten October 8, 2021 01:49
blasten
blasten approved these changes Oct 8, 2021
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow, I thought the flutter tree was green after seeing other folks landing PRs

@godofredoc
Copy link
Contributor

godofredoc commented Oct 8, 2021

Properties from .ci.yaml are not propagating. Manual executions are passing:

https://chromium-swarm.appspot.com/task?id=5676794325f9ed10
https://chromium-swarm.appspot.com/task?id=56767b3d84609310
https://chromium-swarm.appspot.com/task?id=56767f2ec1e2ab10

@godofredoc godofredoc merged commit 5188df0 into flutter:master Oct 8, 2021
@zanderso zanderso deleted the revert-gradle branch October 8, 2021 03:07
@TahaTesser TahaTesser mentioned this pull request Oct 8, 2021
Closed
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@zanderso @clocksmith
Revert gradle roll (flutter#91459)
550db1f 
* Revert "Mark last failing test after gradle update as flaky. (flutter#91423)"

This reverts commit 46a52d0.

* Revert "fix android template for Gradle 7 (flutter#91411)"

This reverts commit 51d06d5.

* Revert "Add explicit version for mac and windows openjdk. (flutter#91408)"

This reverts commit bf429f2.

* Revert "Update the openjdk version used by linux android tests. (flutter#91405)"

This reverts commit 2144ab8.

* Revert "Migrate to Gradle 7.0.2 / AGP 7.0.1 (flutter#90642)"

This reverts commit b6459f9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

+2 more reviewers

@blasten blasten blasten approved these changes

@godofredoc godofredoc godofredoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zanderso @godofredoc @blasten @TahaTesser