Don't generate plugin registry in ResidentWebRunner #91281
Conversation
generateDartPluginRegistry was being set to true unconditionally in ResidentRunner, bypassing the primary check in DartPluginRegistrantTarget, and the targetPlatform was not set in that codepath, bypassing the second after the changes in flutter#87991. This caused web hot restarts to be slower due to doing unnecessary work. This ensures that generateDartPluginRegistry is false in the ResidentWebRunner to skip that unnecessary step. Fixes flutter#91262
flutter-dashboard
bot
added
the
tool
|
/cc @zanderso @christopherfujino FYI. I'm not sure how to run the perf test myself, but I verified locally that the undesired codepath was being run for web hot restart without this change, as is not with this change. |
I don't know of an easier way of seeing how to run the benchmarks than looking at how the bots run them. In this case you can search on the dashboard for "chrome_dev_mode", which leads you to and example run: From there, you probably just need to look at step 17 "run macos_chrome_dev_mode". |
packages/flutter_tools/test/general.shard/resident_web_runner_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Zachary Anderson <[email protected]>
|
@godofredoc the ci.yaml validation looks like it is taking too long to queue on this PR. |
|
|
Gold has detected about 1 new digest(s) on patchset 2. |
|
This pull request is not suitable for automatic merging in its current state.
|
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Any idea why this change affects goldens? |
|
That is weird. maybe a rebase fixes it? |
Yep! No idea what happened there; infra issue maybe? |
stuartmorgan-g
added
waiting for tree to go green
and removed
will affect goldens
|
I think Skia Gold's state is not a function of the files in your local copy. It's a function of whomever approved the last gold files? |
* Don't generate plugin registry in ResidentWebRunner generateDartPluginRegistry was being set to true unconditionally in ResidentRunner, bypassing the primary check in DartPluginRegistrantTarget, and the targetPlatform was not set in that codepath, bypassing the second after the changes in flutter#87991. This caused web hot restarts to be slower due to doing unnecessary work. This ensures that generateDartPluginRegistry is false in the ResidentWebRunner to skip that unnecessary step. Fixes flutter#91262 * Formatting Co-authored-by: Zachary Anderson <[email protected]> Co-authored-by: Zachary Anderson <[email protected]>
7 participants
generateDartPluginRegistry was being set to true unconditionally in
ResidentRunner, bypassing the primary check in
DartPluginRegistrantTarget, and the targetPlatform was not set in that
codepath, bypassing the second after the changes in
#87991. This caused web hot
restarts to be slower due to doing unnecessary work.
This ensures that generateDartPluginRegistry is false in the
ResidentWebRunner to skip that unnecessary step.
Fixes #91262
Pre-launch Checklist
///).