Skip to content

Clean up dependency pins and update all packages #91109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Oct 4, 2021
Merged

Clean up dependency pins and update all packages #91109

fluttergithubbot merged 1 commit into from
Oct 4, 2021

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Oct 1, 2021 •
edited by christopherfujino
Loading

Fixes #91108

@Hixie Hixie requested a review from Piinks as a code owner October 1, 2021 19:14
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 1, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 1, 2021
@google-cla google-cla bot added the cla: yes label Oct 1, 2021
christopherfujino
christopherfujino reviewed Oct 1, 2021
View reviewed changes
dev/benchmarks/complex_layout/pubspec.yaml Outdated
Copy link
Contributor

@christopherfujino christopherfujino Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this got reverted? did you change this, or was it flutter update-packages?

Copy link
Contributor Author

@Hixie Hixie Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd, i did that by accident at one point but i thought i'd fixed it... checking, one sec

Copy link
Contributor Author

@Hixie Hixie Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i forgot to rerun the tool after updating that particular pin, heh. will push new update.

christopherfujino
christopherfujino reviewed Oct 1, 2021
View reviewed changes
dev/benchmarks/complex_layout/pubspec.yaml Outdated
Copy link
Contributor

@christopherfujino christopherfujino Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Hixie Hixie force-pushed the dependencies branch 2 times, most recently from aeacdbe to d75cc83 Compare October 1, 2021 19:21
christopherfujino
christopherfujino approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI passing

@Hixie
Copy link
Contributor Author

Hixie commented Oct 1, 2021

This can land on red as soon as the bots are happy, it is intended to fix the tree redness.

@flar
Copy link
Contributor

flar commented Oct 1, 2021

Will "waiting for tree to go green" work here? This is the cause for the redness...

@flar
Copy link
Contributor

flar commented Oct 1, 2021

Linux_web_tests all failed on timeouts. I'm rerunning "_0" as a test to see if rerunning helps.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Oct 1, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux web_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_tests_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_tests_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_tests_7_last has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_tests_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_tests_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flar
Copy link
Contributor

flar commented Oct 1, 2021

The Linux_web_tests_0 is running long and will likely timeout. Is there something in this PR that could be leading to that?

@christopherfujino christopherfujino mentioned this pull request Oct 1, 2021
Merged
@Hixie Hixie force-pushed the dependencies branch 2 times, most recently from 306a2b3 to 7a52f28 Compare October 1, 2021 20:40
@Hixie
Copy link
Contributor Author

Hixie commented Oct 1, 2021

Will "waiting for tree to go green" work here? This is the cause for the redness...

unfortunately not, see #81568

@flar
Copy link
Contributor

flar commented Oct 1, 2021

It's failing again on the signature even after the force push...?

@Hixie
Copy link
Contributor Author

Hixie commented Oct 1, 2021

Yeah I hadn't finished updating it. This version should be good though!

christopherfujino
christopherfujino reviewed Oct 1, 2021
View reviewed changes
packages/flutter_tools/lib/src/commands/update_packages.dart Outdated
Copy link
Contributor

@christopherfujino christopherfujino Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we're pinning this exactly, I'm guessing we should let the Flutter Material team know? @pennzht

christopherfujino
christopherfujino reviewed Oct 1, 2021
View reviewed changes
packages/flutter_tools/lib/src/commands/update_packages.dart Outdated
Copy link
Contributor

@christopherfujino christopherfujino Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that we ever run this command with asserts. Perhaps this should be an explicit integration test?

Copy link
Contributor Author

@Hixie Hixie Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense. I did an assert because it's private but that's dumb, I should just make it public and test it.

Copy link
Contributor Author

@Hixie Hixie Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Hixie Hixie force-pushed the dependencies branch 2 times, most recently from a5aead2 to 5f47996 Compare October 1, 2021 21:48
christopherfujino
christopherfujino approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluttergithubbot fluttergithubbot merged commit 126cd73 into flutter:master Oct 4, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@Hixie @clocksmith
Clean up dependency pins and update all packages (flutter#91109)
d235810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Awaiting requested review from Piinks

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allowlist signature wrong in Linux analyze

4 participants

@Hixie @flar @fluttergithubbot @christopherfujino