Tabbar view swipe #910
Merged
Tabbar view swipe #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansMuller
force-pushed
the
tabbar_view_swipe
branch
from
03c7c69 to
3229898
Compare
Contributor
|
I'm not familiar enough with this code to give a good review, but LGTM. |
Swiping left or right in a TabBarView now changes the selected tab in the way it's supposed to. Currently swipe gestures that start while the selection change is underway are ignored. Will fix that in a separate change.
HansMuller
force-pushed
the
tabbar_view_swipe
branch
from
3229898 to
80c5e6a
Compare
HansMuller
pushed a commit
that referenced
this pull request
Dec 14, 2015
Tabbar view swipe Swiping left or right in a TabBarView now changes the selected tab in the way it's supposed to. Currently swipe gestures that start while the selection change is underway are ignored. Will fix that in a separate change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swiping left or right in a TabBarView now changes the selected tab in the way it's supposed to.
Currently swipe gestures that start while the selection change is underway are ignored. Will fix that in a separate change.