Skip to content

Add iOS build -destination flag #90915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Oct 4, 2021
Merged

Add iOS build -destination flag #90915

fluttergithubbot merged 1 commit into from
Oct 4, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Sep 29, 2021 •
edited
Loading

Pass a given device ID into the xcodebuild command so it can just build for the targeted architecture (in debug). Default to the "generic" iOS or simulator placeholder devices instead of the first listed.

Fixes #87136
flutter run and flutter build ios -d part of #90382.

@jmagman jmagman self-assigned this Sep 29, 2021
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 29, 2021
@google-cla google-cla bot added the cla: yes label Sep 29, 2021
@jmagman jmagman force-pushed the build-destination branch 3 times, most recently from 7a60ccf to a498c6e Compare September 29, 2021 01:46
@jmagman jmagman marked this pull request as ready for review September 29, 2021 01:55
cyanglaz
cyanglaz approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman mentioned this pull request Sep 29, 2021
Closed
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 29, 2021

This pull request is not suitable for automatic merging in its current state.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 29, 2021

This pull request is not suitable for automatic merging in its current state.

@jmagman
Copy link
Member Author

jmagman commented Oct 4, 2021

Google testing failing because the roll does not yet contain #90304, ignoring.

@fluttergithubbot fluttergithubbot merged commit 61e2e86 into flutter:master Oct 4, 2021
@jmagman jmagman deleted the build-destination branch October 4, 2021 18:14
@darshankawar darshankawar mentioned this pull request Oct 19, 2021
Closed
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@jmagman @clocksmith
Add iOS build -destination flag (flutter#90915)
f418638
@mikaryyn mikaryyn mentioned this pull request Dec 13, 2021
Closed
@jmagman jmagman mentioned this pull request Dec 14, 2021
Merged
8 tasks
@jmagman jmagman added the platform-ios iOS applications specifically label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

On Xcode 13 "flutter build ios -v" prints warning that there are multiple matching destinations

3 participants

@jmagman @fluttergithubbot @cyanglaz