It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

If the app never calls setUrlStrategy(), the web engine will create a default url strategy (see here and here). In this case, your _urlStrategy remains null.

In case there's no call of setUrlStrategy, wouldn't it be nicer anyway if the EngineFlutterWindow directly called setUrlStrategy instead of the hard-coded UrlStrategy in _createDefaultUrlStrategy in https://github.com/flutter/engine/blob/2db431944795e9c556881d77cfefe7159bb58168/lib/web_ui/lib/src/engine/window.dart#L358?

Well, that would harm the tree hygiene as it meant a call from engine to flutter_web_plugins.

The other way would be keeping in sync the default UrlStrategy as already pointed out in

I am unsure whether / how I can cover the affiliation with https://github.com/flutter/engine/blob/master/lib/web_ui/lib/src/engine/window.dart#L360 in a test. Do you have an idea of it?

@mdebbar Does it look eligible now?

I'm not sure why some of the checks are stuck. You may need to rebase and push to get them to run again.

It looks like the framework_tests-misc-linux does not like to pass even though I rebased. Do you have an idea why?

I think something went wrong with the rebase and we ended up with 140 commits. The PR in its current form is not going to work, it needs to be cleaned up.

Do you remember how you rebased? It might help us get things back to normal.

If you can get back to a state that only contains your commits, we can redo the rebase correctly. If you aren't too familiar with git, let me know and I'll help.

Should be squashed now. Could you check whether it's fine now, @mdebbar?

Alright, squashing did it 😄

Let's wait and see what the tests have to say.