Fix Chip tooltip so that useDeleteButtonTooltip only applies to the delete button. #90464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
gspencergoog
requested review from
LongCatIsLooong,
darrenaustin and
goderbauer
and removed request for
goderbauer
gspencergoog
force-pushed
the
fix_chip_tooltip
branch
from
a64cd40 to
5310740
Compare
darrenaustin
approved these changes
Sep 23, 2021
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
LGTM. Nice cleanup.
gspencergoog
force-pushed
the
fix_chip_tooltip
branch
from
5310740 to
110fa12
Compare
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
…elete button. (flutter#90464) This fixes flutter#90044 by limiting the effect of useDeleteButtonTooltip to the delete button, instead of both the main tooltip and the delete button. This means that when useDeleteButtonTooltip was false, it used to not display the main tooltip either, but now it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #90044 by limiting the effect of
useDeleteButtonTooltipto the delete button, instead of both the main tooltip and the delete button. This means that whenuseDeleteButtonTooltipwas false, it used to not display the main tooltip either, but now it does.Related Issues
Tests
useDeleteButtonTooltiponly applies to the delete button.