Skip to content

Conversation

@krispypen
Copy link
Contributor

Fix typo in flutter gen-l10n help. It should be false to return a non-nullable object.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 16, 2021
@google-cla google-cla bot added the cla: yes label Sep 16, 2021
@christopherfujino
Copy link
Contributor

@krispypen nice catch! Can you add a test for this? You can add it to this file: https://github.com/christopherfujino/flutter/blob/pub-bat-show-dir/packages/flutter_tools/test/commands.shard/hermetic/generate_localizations_test.dart and it can be as simple as asserting that GenerateLocalizationsCommand(...).usage has the right string.

@christopherfujino
Copy link
Contributor

Closing this as inactive. Feel free to re-open if you want to revisit (and address feedback).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants