-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Correct font weight for Cupertino tab label #90109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SimonHausdorf welcome! And thank you for the contribution. This will need a test to verify the change, and to prevent it from regressing in the future. Can you add a test?
|
@SimonHausdorf Is this a PR you are still interested in working on? |
|
@Hixie maybe someone else could contribute to the test part? I am not exactly sure what the test should contain or how it would look like. |
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SimonHausdorf thanks for coming back to this and adding a test! Can you rebase with master to update your branch? That should resolve the failing checks.
|
@Piinks some tests are still failing but I assume they are not related to the PR? |
|
I see, thanks for pinging. In this case, you will need to rebase in order to resolve those test failures. Enough time has passed for this PR that merging causes issues for some tests (#97595). |
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This pull request is not suitable for automatic merging in its current state.
|
|
Oh whoops, I forgot this needs 2 reviews, I have reached out to the team for another reviewer |

Based on the sketch file from https://developer.apple.com/design/resources/ the tab bar label has a font weigh for medium / 500.
Original iOS tab bar
Top: Cupertino without font weight, bottom: changed font weight to medium
fixes #90108