Skip to content

Renew cirrus gcp credentials #89988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
keyonghan merged 1 commit into from
Sep 13, 2021
Merged

Renew cirrus gcp credentials #89988

keyonghan merged 1 commit into from
Sep 13, 2021

Conversation

@keyonghan
Copy link
Contributor

@keyonghan keyonghan commented Sep 13, 2021

GCP account key expires every three months. This CL updates the GCP credential based on the renewed key.

@google-cla google-cla bot added the cla: yes label Sep 13, 2021
@jmagman jmagman mentioned this pull request Sep 13, 2021
Closed
@keyonghan
Copy link
Contributor Author

keyonghan commented Sep 13, 2021

Cirrus Build Parsing Results failure can be ignored per #89993 (comment)

godofredoc
godofredoc reviewed Sep 13, 2021
View reviewed changes
Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to fix the warnings?

@keyonghan
Copy link
Contributor Author

keyonghan commented Sep 13, 2021

Do we need to fix the warnings?

This is some side effect of cirrus side changes, and can be ignored: #89993 (comment)

justinmc
justinmc approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@keyonghan keyonghan merged commit 00f78cf into flutter:master Sep 13, 2021
guidezpl added a commit that referenced this pull request Sep 15, 2021
@guidezpl
Add semanticsLabel to SelectableText (#89369)
b129fff 
* add `semanticsLabel` to `SelectableText`

* remove unused vars

* Squashed commit of the following:

commit 3e687a9
Author: engine-flutter-autoroll <[email protected]>
Date:   Tue Sep 14 17:42:05 2021 -0400

    Roll Plugins from 4a98e23 to b85edeb (2 revisions) (#90083)

commit ad936b4
Author: Christopher Fujino <[email protected]>
Date:   Tue Sep 14 14:39:17 2021 -0700

    [flutter_conductor] Support initial stable release version (#89775)

commit ff5dd54
Author: Ian Hickson <[email protected]>
Date:   Tue Sep 14 13:02:04 2021 -0700

    Mention the ToS on our README (#89765)

commit 8587b60
Author: Kate Lovett <[email protected]>
Date:   Tue Sep 14 14:53:33 2021 -0500

    Update local gold api (#90072)

commit 7d368dc
Author: Justin McCandless <[email protected]>
Date:   Tue Sep 14 12:39:19 2021 -0700

    InteractiveViewer with a child of zero size (#90012)

    Asserts that the InteractiveViewer child can't have zero size.

commit 2b4ef18
Author: Akira Aratani <[email protected]>
Date:   Wed Sep 15 03:30:50 2021 +0900

    Fix document of the switch. (#89641)

commit a2cd16b
Author: Christopher Fujino <[email protected]>
Date:   Tue Sep 14 11:22:02 2021 -0700

    use test logger, which does not allow colors (#90010)

commit 0f0613c
Author: Varun Sharma <[email protected]>
Date:   Tue Sep 14 11:17:03 2021 -0700

    Add specific permissions to .github/workflows/lock.yaml (#89820)

commit 2866f79
Author: Jason Simmons <[email protected]>
Date:   Tue Sep 14 10:46:35 2021 -0700

    Initialize all bindings before starting the text_editing_action_target test suite (#90067)

    Fixes #90057

commit b889915
Author: Michael Thomsen <[email protected]>
Date:   Tue Sep 14 14:08:36 2021 +0200

    Change min Dart SDK constraint to track actual version (#88743)

commit 3b7adb9
Author: godofredoc <[email protected]>
Date:   Mon Sep 13 21:32:04 2021 -0700

    Lock only issues. (#90023)

commit 528f77d
Author: Dan Field <[email protected]>
Date:   Mon Sep 13 19:10:15 2021 -0700

    Opacity fix (#90017)

    * Make sure Opacity widgets/layers do not drop the offset

commit 2470f63
Author: engine-flutter-autoroll <[email protected]>
Date:   Mon Sep 13 22:07:02 2021 -0400

    4a98e23 [flutter_plugin_tools] Make no unit tests fatal for iOS/macOS (flutter/plugins#4341) (#90016)

commit a01e473
Author: stuartmorgan <[email protected]>
Date:   Mon Sep 13 20:57:05 2021 -0400

    Re-enable plugin analysis test (#89856)

commit cdad35f
Author: Aneesh Rao <[email protected]>
Date:   Tue Sep 14 05:17:04 2021 +0530

    Fix path in example (#84707)

commit 576aab0
Author: Christopher Fujino <[email protected]>
Date:   Mon Sep 13 15:47:03 2021 -0700

    add analysis_options.yaml to dev/conductor (#90005)

commit fad5e4c
Author: Jason Simmons <[email protected]>
Date:   Mon Sep 13 13:37:07 2021 -0700

    Remove a redundant test case in the flutter_tools create_test (#89872)

commit 738430c
Author: Darren Austin <[email protected]>
Date:   Mon Sep 13 13:33:48 2021 -0700

    Revert "Removed default page transitions for desktop and web platforms. (#82596)" (#89997)

    This reverts commit 43e3197

commit 9db9256
Author: Dan Field <[email protected]>
Date:   Mon Sep 13 13:15:19 2021 -0700

    Revert "Make sure Opacity widgets/layers do not drop the offset (#89264)" (#89999)

    This reverts commit 0d0f7a4.

commit 00f78cf
Author: keyonghan <[email protected]>
Date:   Mon Sep 13 13:04:01 2021 -0700

    renew cirrus key (#89988)

commit 826da7f
Author: engine-flutter-autoroll <[email protected]>
Date:   Mon Sep 13 15:52:03 2021 -0400

    cfc8a20 renew cirrus key (flutter/plugins#4340) (#89996)

commit cd112e5
Author: Anna Gringauze <[email protected]>
Date:   Mon Sep 13 12:13:42 2021 -0700

    Update all packages (#89797)
@christopherfujino christopherfujino mentioned this pull request Sep 15, 2021
Merged
renyou pushed a commit to renyou/flutter that referenced this pull request Sep 15, 2021
@keyonghan @renyou
renew cirrus key (flutter#89988)
20aca0c
renyou added a commit that referenced this pull request Sep 15, 2021
@renyou @dnfield @keyonghan
Opacity fix (#90017) (#90143)
178ef57 
* Opacity fix (#90017)

* Make sure Opacity widgets/layers do not drop the offset

* Update ci.yaml to enable the tests

* renew cirrus key (#89988)

Co-authored-by: Dan Field <[email protected]>
Co-authored-by: keyonghan <[email protected]>
christopherfujino added a commit that referenced this pull request Sep 17, 2021
@Yugue @dkwingsmt
@Piinks @darrenaustin @christopherfujino @keyonghan
[flutter_releases] Flutter stable 2.5.1 Framework Cherrypicks (#90281)
ffb2ece 
* Fix KeyboardManager's synthesization  (#88967)

This PR fixes KeyboardManager's key event synthesization logic, which were dispatching events with incorrect keys, making subsequent key events crash the app.

* Revert clamping scroll simulation changes (#89885)

* Revert "Removed default page transitions for desktop and web platforms. (#82596)" (#89997)

This reverts commit 43e3197

* 'Update Engine revision to b3af521a050e6ef076778bcaf16e27b2521df8f8 for stable release 2.5.1'

* Update dds 2.0.3 -> 2.0.4

* renew cirrus key (#89988)

Co-authored-by: Tong Mu <[email protected]>
Co-authored-by: Kate Lovett <[email protected]>
Co-authored-by: Darren Austin <[email protected]>
Co-authored-by: Christopher Fujino <[email protected]>
Co-authored-by: keyonghan <[email protected]>
tomasz-karczewski-red pushed a commit to tomasz-karczewski-red/flutter that referenced this pull request Sep 23, 2021
@Yugue @dkwingsmt
@Piinks @darrenaustin @christopherfujino @keyonghan @tomasz-karczewski-red
[flutter_releases] Flutter stable 2.5.1 Framework Cherrypicks (flutte…
e55ca73 
…r#90281)

* Fix KeyboardManager's synthesization  (flutter#88967)

This PR fixes KeyboardManager's key event synthesization logic, which were dispatching events with incorrect keys, making subsequent key events crash the app.

* Revert clamping scroll simulation changes (flutter#89885)

* Revert "Removed default page transitions for desktop and web platforms. (flutter#82596)" (flutter#89997)

This reverts commit 43e3197

* 'Update Engine revision to b3af521a050e6ef076778bcaf16e27b2521df8f8 for stable release 2.5.1'

* Update dds 2.0.3 -> 2.0.4

* renew cirrus key (flutter#89988)

Co-authored-by: Tong Mu <[email protected]>
Co-authored-by: Kate Lovett <[email protected]>
Co-authored-by: Darren Austin <[email protected]>
Co-authored-by: Christopher Fujino <[email protected]>
Co-authored-by: keyonghan <[email protected]>
abhishekprofcyma pushed a commit to abhishekprofcyma/flutter that referenced this pull request Dec 2, 2021
@akshaysworld-source @dkwingsmt
@Piinks @darrenaustin @christopherfujino @keyonghan
[flutter_releases] Flutter stable 2.5.1 Framework Cherrypicks (flutte…
18664e4 
…r#90281)

* Fix KeyboardManager's synthesization  (flutter#88967)

This PR fixes KeyboardManager's key event synthesization logic, which were dispatching events with incorrect keys, making subsequent key events crash the app.

* Revert clamping scroll simulation changes (flutter#89885)

* Revert "Removed default page transitions for desktop and web platforms. (flutter#82596)" (flutter#89997)

This reverts commit 43e3197

* 'Update Engine revision to b3af521a050e6ef076778bcaf16e27b2521df8f8 for stable release 2.5.1'

* Update dds 2.0.3 -> 2.0.4

* renew cirrus key (flutter#89988)

Co-authored-by: Tong Mu <[email protected]>
Co-authored-by: Kate Lovett <[email protected]>
Co-authored-by: Darren Austin <[email protected]>
Co-authored-by: Christopher Fujino <[email protected]>
Co-authored-by: keyonghan <[email protected]>
@keyonghan keyonghan deleted the renew_cirrus_key branch December 7, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

+1 more reviewer

@godofredoc godofredoc godofredoc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keyonghan @justinmc @godofredoc