Revert clamping scroll simulation changes #89885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
c: regression
flutter-dashboard
bot
added
a: accessibility
Piinks
commented
Sep 10, 2021
Comment on lines
+47
to
+51
| // Regression test for https://github.com/flutter/flutter/issues/83632 | ||
| // Before changing these values, ensure the fling results in a distance that | ||
| // makes sense. See issue for more context. | ||
| expect(androidResult, greaterThan(394.0)); | ||
| expect(androidResult, lessThan(395.0)); |
Contributor
Author
There was a problem hiding this comment.
I added this to draw attention to any future regressions. The rest of the PR is a straight revert from the original.
Member
|
We should probably cherry-pick this into the latest release. |
Contributor
Author
|
I agree, I'll label the issue for cp once this lands |
christopherfujino
added a commit
that referenced
this pull request
Sep 17, 2021
* Fix KeyboardManager's synthesization (#88967) This PR fixes KeyboardManager's key event synthesization logic, which were dispatching events with incorrect keys, making subsequent key events crash the app. * Revert clamping scroll simulation changes (#89885) * Revert "Removed default page transitions for desktop and web platforms. (#82596)" (#89997) This reverts commit 43e3197 * 'Update Engine revision to b3af521a050e6ef076778bcaf16e27b2521df8f8 for stable release 2.5.1' * Update dds 2.0.3 -> 2.0.4 * renew cirrus key (#89988) Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Darren Austin <[email protected]> Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: keyonghan <[email protected]>
tomasz-karczewski-red
pushed a commit
to tomasz-karczewski-red/flutter
that referenced
this pull request
Sep 23, 2021
…r#90281) * Fix KeyboardManager's synthesization (flutter#88967) This PR fixes KeyboardManager's key event synthesization logic, which were dispatching events with incorrect keys, making subsequent key events crash the app. * Revert clamping scroll simulation changes (flutter#89885) * Revert "Removed default page transitions for desktop and web platforms. (flutter#82596)" (flutter#89997) This reverts commit 43e3197 * 'Update Engine revision to b3af521a050e6ef076778bcaf16e27b2521df8f8 for stable release 2.5.1' * Update dds 2.0.3 -> 2.0.4 * renew cirrus key (flutter#89988) Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Darren Austin <[email protected]> Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: keyonghan <[email protected]>
abhishekprofcyma
pushed a commit
to abhishekprofcyma/flutter
that referenced
this pull request
Dec 2, 2021
…r#90281) * Fix KeyboardManager's synthesization (flutter#88967) This PR fixes KeyboardManager's key event synthesization logic, which were dispatching events with incorrect keys, making subsequent key events crash the app. * Revert clamping scroll simulation changes (flutter#89885) * Revert "Removed default page transitions for desktop and web platforms. (flutter#82596)" (flutter#89997) This reverts commit 43e3197 * 'Update Engine revision to b3af521a050e6ef076778bcaf16e27b2521df8f8 for stable release 2.5.1' * Update dds 2.0.3 -> 2.0.4 * renew cirrus key (flutter#89988) Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Darren Austin <[email protected]> Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: keyonghan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #77497 which sought to address #16371
The original change caused a regression in #83632
Fixes #83632
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.