Run the flutter_tools create test in online mode before testing offline mode #89779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne mode Offline pub assumes that the pub cache contains all needed packages. Running "flutter create" in online mode first will ensure that the pub cache is populated. Fixes flutter#89759
flutter-dashboard
bot
added
the
tool
Contributor
|
why are we failing to find the dart binary? |
zanderso
approved these changes
Sep 9, 2021
|
|
||
| testUsingContext( | ||
| 'invokes pub offline when requested', | ||
| 'invokes pub in online and offline modes', |
Member
There was a problem hiding this comment.
If this is only testing that the --offline flag is or isn't plumbed through correctly, can it use a fake filesystem and process runner instead? We can land this to get the tree green etc. but if this is just testing flag plumbing there's no reason to invoke the real pub, I think?
Contributor
There was a problem hiding this comment.
that makes sense to me
christopherfujino
approved these changes
Sep 9, 2021
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM. I still don't understand why we get the dart bin not found exception, but this looks like it will green the tree.
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Sep 13, 2021
This test was merged into another test in flutter#89779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offline pub assumes that the pub cache contains all needed packages. Running
"flutter create" in online mode first will ensure that the pub cache is populated.
Fixes #89759