Skip to content

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Sep 9, 2021

fixes: #89776

Previously, there was no way for the conductor to produce a stable release version x.y.0. If a conductor session was started where the increment level was set to z, but the previous version was a dev-style version (e.g. 1.2.0-3.4.pre), the tool would throw an exception. This change modifies the tool to specifically detect this situation, and hard-code the z value to 0.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 9, 2021
@google-cla google-cla bot added the cla: yes label Sep 9, 2021
@christopherfujino
Copy link
Contributor Author

cc @Yugue

Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter-lgtm

@christopherfujino
Copy link
Contributor Author

tool_test failure is an unrelated test issue, that was just fixed in #89779:

16:44 +370 -1: test\commands.shard\permeable\create_test.dart: invokes pub offline when requested [E]                                                                                                  
  TimeoutException after 0:15:00.000000: Test timed out after 15 minutes.
  dart:isolate  _RawReceivePortImpl._handleMessage

I will rebase

@CaseyHillers
Copy link
Contributor

@Yugue for reference, @christopherfujino was able to identify the failure as not his via following the Discord chat, but you can also check https://flutter-dashboard.appspot.com/#/build to see if any of your tests are failing there. In this instance, we randomize the tests daily, and today showed a failure that needed to be fixed. So doing git fetch upstream && git rebase upstream/master fixed his PR.

@christopherfujino
Copy link
Contributor Author

lol, I was too slow, now another upstream failure has been introduced :P

#89792

@christopherfujino christopherfujino merged commit ad936b4 into flutter:master Sep 14, 2021
@christopherfujino christopherfujino deleted the conductor-tool-update branch September 14, 2021 21:39
guidezpl added a commit that referenced this pull request Sep 15, 2021
* add `semanticsLabel` to `SelectableText`

* remove unused vars

* Squashed commit of the following:

commit 3e687a9
Author: engine-flutter-autoroll <[email protected]>
Date:   Tue Sep 14 17:42:05 2021 -0400

    Roll Plugins from 4a98e23 to b85edeb (2 revisions) (#90083)

commit ad936b4
Author: Christopher Fujino <[email protected]>
Date:   Tue Sep 14 14:39:17 2021 -0700

    [flutter_conductor] Support initial stable release version (#89775)

commit ff5dd54
Author: Ian Hickson <[email protected]>
Date:   Tue Sep 14 13:02:04 2021 -0700

    Mention the ToS on our README (#89765)

commit 8587b60
Author: Kate Lovett <[email protected]>
Date:   Tue Sep 14 14:53:33 2021 -0500

    Update local gold api (#90072)

commit 7d368dc
Author: Justin McCandless <[email protected]>
Date:   Tue Sep 14 12:39:19 2021 -0700

    InteractiveViewer with a child of zero size (#90012)

    Asserts that the InteractiveViewer child can't have zero size.

commit 2b4ef18
Author: Akira Aratani <[email protected]>
Date:   Wed Sep 15 03:30:50 2021 +0900

    Fix document of the switch. (#89641)

commit a2cd16b
Author: Christopher Fujino <[email protected]>
Date:   Tue Sep 14 11:22:02 2021 -0700

    use test logger, which does not allow colors (#90010)

commit 0f0613c
Author: Varun Sharma <[email protected]>
Date:   Tue Sep 14 11:17:03 2021 -0700

    Add specific permissions to .github/workflows/lock.yaml (#89820)

commit 2866f79
Author: Jason Simmons <[email protected]>
Date:   Tue Sep 14 10:46:35 2021 -0700

    Initialize all bindings before starting the text_editing_action_target test suite (#90067)

    Fixes #90057

commit b889915
Author: Michael Thomsen <[email protected]>
Date:   Tue Sep 14 14:08:36 2021 +0200

    Change min Dart SDK constraint to track actual version (#88743)

commit 3b7adb9
Author: godofredoc <[email protected]>
Date:   Mon Sep 13 21:32:04 2021 -0700

    Lock only issues. (#90023)

commit 528f77d
Author: Dan Field <[email protected]>
Date:   Mon Sep 13 19:10:15 2021 -0700

    Opacity fix (#90017)

    * Make sure Opacity widgets/layers do not drop the offset

commit 2470f63
Author: engine-flutter-autoroll <[email protected]>
Date:   Mon Sep 13 22:07:02 2021 -0400

    4a98e23 [flutter_plugin_tools] Make no unit tests fatal for iOS/macOS (flutter/plugins#4341) (#90016)

commit a01e473
Author: stuartmorgan <[email protected]>
Date:   Mon Sep 13 20:57:05 2021 -0400

    Re-enable plugin analysis test (#89856)

commit cdad35f
Author: Aneesh Rao <[email protected]>
Date:   Tue Sep 14 05:17:04 2021 +0530

    Fix path in example (#84707)

commit 576aab0
Author: Christopher Fujino <[email protected]>
Date:   Mon Sep 13 15:47:03 2021 -0700

    add analysis_options.yaml to dev/conductor (#90005)

commit fad5e4c
Author: Jason Simmons <[email protected]>
Date:   Mon Sep 13 13:37:07 2021 -0700

    Remove a redundant test case in the flutter_tools create_test (#89872)

commit 738430c
Author: Darren Austin <[email protected]>
Date:   Mon Sep 13 13:33:48 2021 -0700

    Revert "Removed default page transitions for desktop and web platforms. (#82596)" (#89997)

    This reverts commit 43e3197

commit 9db9256
Author: Dan Field <[email protected]>
Date:   Mon Sep 13 13:15:19 2021 -0700

    Revert "Make sure Opacity widgets/layers do not drop the offset (#89264)" (#89999)

    This reverts commit 0d0f7a4.

commit 00f78cf
Author: keyonghan <[email protected]>
Date:   Mon Sep 13 13:04:01 2021 -0700

    renew cirrus key (#89988)

commit 826da7f
Author: engine-flutter-autoroll <[email protected]>
Date:   Mon Sep 13 15:52:03 2021 -0400

    cfc8a20 renew cirrus key (flutter/plugins#4340) (#89996)

commit cd112e5
Author: Anna Gringauze <[email protected]>
Date:   Mon Sep 13 12:13:42 2021 -0700

    Update all packages (#89797)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_conductor] conductor should support initial stable release versions

2 participants