Updated complex_layout ios project according to #8971 #8974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Mar 23, 2017
Member
|
Thanks! |
Contributor
Author
|
Np. I'm still working on doing the same thing for microbenchmarks. But it
has no main.dart, and so cannot be built by flutter tooling as it stands.
I'm trying to add a dummy main.dart, then we'll see how it goes.
…On Thu, Mar 23, 2017 at 9:14 AM, Chris Bracken ***@***.***> wrote:
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8974 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AV33XcsQgitpS6YxS-RVW6gM_Ahe0UNUks5rointgaJpZM4MmYd7>
.
--
Mikkel Nygaard Ravn
Software Engineer
|
Contributor
Author
|
Hi Chris,
I was not able to follow your step 8,
In the Xcode project navigator, select *Flutter*, then from the
*File* menu, select *Add Files to "Runner"...*. Navigate to the
*ios/Flutter* directory, select *AppFrameworkInfo.plist* and click
the *Add* button.
There was no AppFrameworkInfo.plist in sight, so I copied that from
hello_world.
…On Thu, Mar 23, 2017 at 9:17 AM, Mikkel Ravn ***@***.***> wrote:
Np. I'm still working on doing the same thing for microbenchmarks. But it
has no main.dart, and so cannot be built by flutter tooling as it stands.
I'm trying to add a dummy main.dart, then we'll see how it goes.
On Thu, Mar 23, 2017 at 9:14 AM, Chris Bracken ***@***.***>
wrote:
> Thanks!
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#8974 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AV33XcsQgitpS6YxS-RVW6gM_Ahe0UNUks5rointgaJpZM4MmYd7>
> .
>
--
Mikkel Nygaard Ravn
Software Engineer
--
Mikkel Nygaard Ravn
Software Engineer
|
Member
|
Agh that's a good point -- I'll update the steps to suggest copying one from the repo. Thanks for reporting! |
Member
|
Done. Posted a download link in the #8971 instructions that pulls it from the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8971