Skip to content

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Sep 7, 2021

Fixes #84884

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 7, 2021
@google-cla google-cla bot added the cla: yes label Sep 7, 2021
enableAuthCodes: disableServiceAuthCodes != true,
ipv6: ipv6 == true,
// Enables caching of CPU samples collected during application startup.
cachedUserTags: const <String>['AppStartUp'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any documentation of supported tags that we could link to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, this works for any set UserTag, so this is something that could be exposed as a CLI option at some point so users can cache samples associated with any UserTag defined in their code. However, I think it's best to just start with this single case so we can make progress on tooling for profiling application startup times.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, so UserTags are defined in user code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, but we're setting this particular tag in the engine and resetting to default in the framework after everything's initialized. See UserTag.

@fluttergithubbot fluttergithubbot merged commit 619121b into master Sep 9, 2021
@fluttergithubbot fluttergithubbot deleted the app_startup_sample_caching branch September 9, 2021 00:22
jmagman added a commit that referenced this pull request Sep 9, 2021
jmagman added a commit that referenced this pull request Sep 9, 2021
bkonyi added a commit that referenced this pull request Sep 23, 2021
bkonyi added a commit that referenced this pull request Sep 27, 2021
bkonyi added a commit that referenced this pull request Oct 7, 2021
bkonyi added a commit that referenced this pull request Oct 13, 2021
bkonyi added a commit that referenced this pull request Oct 13, 2021
bkonyi added a commit that referenced this pull request Oct 13, 2021
bkonyi added a commit that referenced this pull request Oct 20, 2021
bkonyi added a commit that referenced this pull request Oct 21, 2021
bkonyi added a commit that referenced this pull request Oct 21, 2021
bkonyi added a commit that referenced this pull request Oct 21, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
bkonyi added a commit that referenced this pull request Feb 18, 2022
bkonyi added a commit that referenced this pull request Feb 18, 2022
zanderso added a commit that referenced this pull request Feb 19, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
bkonyi added a commit that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add AppStartUp UserTag to track timing of Flutter app start

4 participants