-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Enable caching of CPU samples collected at application startup #89600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| enableAuthCodes: disableServiceAuthCodes != true, | ||
| ipv6: ipv6 == true, | ||
| // Enables caching of CPU samples collected during application startup. | ||
| cachedUserTags: const <String>['AppStartUp'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any documentation of supported tags that we could link to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, this works for any set UserTag, so this is something that could be exposed as a CLI option at some point so users can cache samples associated with any UserTag defined in their code. However, I think it's best to just start with this single case so we can make progress on tooling for profiling application startup times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, so UserTags are defined in user code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, but we're setting this particular tag in the engine and resetting to default in the framework after everything's initialized. See UserTag.
flutter#89600)" (flutter#90611) This reverts commit 58944e6.
…n startup (flutter#89600)" (flutter#90611)" (flutter#91754) This reverts commit e89a885.
flutter#89600)" (flutter#92220) This reverts commit dc7fea8.
…n startup (flutter#89600)" (flutter#92220)" (flutter#92235) This reverts commit ba0321e.
flutter#89600)" (flutter#98769) This reverts commit ac3c443.
Fixes #84884