Refactor platform_services sample #8949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mit-mit
reviewed
Mar 22, 2017
Member
mit-mit
left a comment
mit-mit
left a comment
There was a problem hiding this comment.
Thanks, looks great. But looks like you missed the throw part?
| response.error("UNAVAILABLE", "Battery level not available.", null); | ||
| } | ||
| } else { | ||
| throw new IllegalArgumentException("Unknown method " + call.method); |
Member
There was a problem hiding this comment.
I think you missed the throw part?
| response.error("UNAVAILABLE", "Battery level not available.", null); | ||
| } | ||
| } else { | ||
| throw new IllegalArgumentException("Unknown method " + call.method); |
Contributor
There was a problem hiding this comment.
I think we should handle unknown methods by response.error too. That's what we'll have to do on the iOS side, because of the difficulty of manual memory management in face of exceptions.
Contributor
Author
There was a problem hiding this comment.
As discussed, removed the exception for now.
mravn-google
approved these changes
Mar 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.