Add smoke tests for all the examples, fix 17 broken examples. #89021

gspencergoog · 2021-08-27T03:51:14Z

Description

This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.

The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.

The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.

Epilepsy warning: the following image flickers a lot.

example_smoke.mp4

Related Issues

Fixes MaterialStateOutlinedBorder interactive app is broken #83987

Tests

Add smoke tests for 239 example apps.

christopherfujino · 2021-09-24T17:21:11Z

dev/tools/examples_smoke_test.dart

TIL about exitCode. Is this equivalent to exit(4);?

Yes, except that it allows for a clean shutdown. If you call exit(4), then if the main is wrapped (e.g. in an integration test) then the test shutdown doesn't occur cleanly (it just exits the app immediately), and not all results are reported.

christopherfujino · 2021-09-24T17:23:13Z

dev/tools/examples_smoke_test.dart

does the glob and path separator work on windows?

Yes, in git it does.

ahh, so the glob is expanded by git?

christopherfujino

LGTM

Piinks

LGTM after confirming test coverage, but I think since the sample code tests exposed those issues, I am guessing they provide test coverage

Piinks · 2021-09-24T22:35:33Z

dev/ci/docker_linux/Dockerfile

Nit: this can be updated further

Oh, good point. Done.

Piinks · 2021-09-24T22:39:12Z

dev/tools/examples_smoke_test.dart

Piinks · 2021-09-24T23:02:49Z

packages/flutter/lib/src/painting/_network_image_io.dart

Is there a test for this? Or does the sample code test cover it?

There wasn't a test. This failed because List<int> wasn't castable to Null, and if there isn't anything to drain, it tries to do that (the docs say "The [futureValue] must not be omitted if null is not assignable to [E].", and it was omitting the return value). The example smoke test doesn't cover this, I just found it when I was playing with one of the examples.

I modified the Fake implementation in image_provider_network_image_test.dart to mirror the implementation in Stream (since the fake "implements" it, not derives from it) to make sure that NetworkImage always passes something to drain. It fails before, and passes now.

Piinks · 2021-09-24T23:03:28Z

packages/flutter/lib/src/widgets/transitions.dart

Same here, does this need a test? Or does the sample code test ensure this?

I added a test for this, which needed to be done, since there wasn't any test at all for RelativePositionedTransition. The test uses a RectTween, which is an Animation<Rect?>, so it exercises this issue.

This was just a null-saftey conversion error: it's silly to not be able to use a RectTween with this. Probably happened because there was no test at all.

…r#89021) This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework. The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead. The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.

google-cla bot added the cla: yes label Aug 27, 2021

gspencergoog force-pushed the test_samples branch 2 times, most recently from 778ba40 to d8d07fd Compare August 27, 2021 18:42

This was referenced Aug 27, 2021

Fix (Vertical)Divider samples & docs #89062

Merged

Fix ThemeData example code snippet #89070

Closed

gspencergoog force-pushed the test_samples branch from 854382c to 24e48fc Compare August 27, 2021 23:23

HansMuller mentioned this pull request Aug 30, 2021

MaterialStateOutlinedBorder interactive app is broken #83987

Closed

gspencergoog force-pushed the test_samples branch 11 times, most recently from cb0f5df to 56c6ae4 Compare September 1, 2021 20:26

gspencergoog force-pushed the test_samples branch 7 times, most recently from 149dfaf to ea09a18 Compare September 9, 2021 17:40

gspencergoog force-pushed the test_samples branch 10 times, most recently from 4644b71 to aa9b7e5 Compare September 23, 2021 22:26

gspencergoog mentioned this pull request Sep 24, 2021

LUCI Bots are unable to run Flutter desktop apps on Linux #90676

Closed

gspencergoog force-pushed the test_samples branch 2 times, most recently from 179d984 to a2b3a97 Compare September 24, 2021 16:32

gspencergoog marked this pull request as ready for review September 24, 2021 16:33

gspencergoog requested review from Piinks and christopherfujino as code owners September 24, 2021 16:33

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 24, 2021

christopherfujino reviewed Sep 24, 2021

View reviewed changes

christopherfujino approved these changes Sep 24, 2021

View reviewed changes

Piinks approved these changes Sep 24, 2021

View reviewed changes

gspencergoog force-pushed the test_samples branch from a2b3a97 to 3b6d43e Compare September 27, 2021 20:51

gspencergoog added 2 commits September 28, 2021 08:21

Add smoke tests for all the examples, fix 17 broken examples.

f01d5de

Pushing empty change to restart CI, since one job never started

4529372

gspencergoog force-pushed the test_samples branch from 93e9b9b to 4529372 Compare September 28, 2021 15:21

gspencergoog merged commit ab2b085 into flutter:master Sep 28, 2021

gspencergoog deleted the test_samples branch September 28, 2021 16:32

amanv8060 mentioned this pull request Jan 18, 2022

Nullability bug in _network_image.io.dart #88733

Closed

lamnhan066 mentioned this pull request Apr 22, 2024

Update examples/api for android platform #147102

Merged

9 tasks

Add smoke tests for all the examples, fix 17 broken examples. #89021

Add smoke tests for all the examples, fix 17 broken examples. #89021

Uh oh!

Conversation

gspencergoog commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gspencergoog commented Aug 27, 2021 •

edited

Loading