Document multi-timeline usage #88604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Seems reasonable, it sounds like we should add an additional Then recommend users run something like: |
Contributor
Author
|
That SGTM |
Contributor
I can send a PR for this. |
Contributor
|
Thank you, @abd99! |
goderbauer
added
the
f: integration_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74930 again.
The previous attempt tried to handle this automatically, but it doesn't work - other callers can and do use
writeResponseDatafor a variety of tasks, and thereportDataobject is not always used for timelines. At least this way we document how to handle multi-timeline tests.@johnpryan @blasten