Stop ignoring strong_mode_down_cast_composites (#8783)
#8853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
|
|
pq
added a commit
to dart-lang/sdk
that referenced
this pull request
Mar 17, 2017
As `strong_mode_down_cast_composite` is now a strong-mode hint these should no longer need to be explicitly ignored. Follow-up from: flutter/flutter#8853 BUG= [email protected] Review-Url: https://codereview.chromium.org/2755013003 .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buying down some
ignoredebt!Thanks to @kasperl , as of
dev-9.0,strong_mode_down_cast_compositeis a strong-mode hint and no longer needs to be ignored. 🤘Fixes: #8783
@Hixie @abarth @eseidelGoogle