Explicitly declare android:exported in examples' manifest
#88502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: examples
This is a prerequisite for bumping the target SDK. https://developer.android.com/about/versions/12/behavior-changes-12#exported
Contributor
|
cc @blasten for review |
blasten
approved these changes
Dec 1, 2021
blasten
left a comment
blasten
left a comment
There was a problem hiding this comment.
This LGTM. There are a few more manifests that need android:exported="true" either now, or in the near future once they bump the target SDK version.
Contributor
|
What's the status of this PR? Is it still relevant? |
Hixie
approved these changes
Apr 19, 2022
Contributor
Hixie
left a comment
Hixie
left a comment
There was a problem hiding this comment.
LGTM in case all that's blocking this is needing a second review
blasten
added
waiting for tree to go green
platform-android
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2022
egramond
pushed a commit
to egramond/flutter
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for bumping the target SDK.
https://developer.android.com/about/versions/12/behavior-changes-12#exported
List which issues are fixed by this PR. You must list at least one issue. I don't think there is an issue filed for this yet. This only takes effect if we set target SDK >= 31.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.