-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Revert "Reland "Android Q transition by default (#82670)"" #88482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
What we would want here is a transition that used raster operations to both zoom and fade the widget. Unfortunately our zoom and our fade widgets operate independently so they would fight over who was creating the raster copy. Eventually I could see this working via the following technique - an Opacity widget wrapping a raster scale widget with the scale widget caching the transitioning child and the opacity widget simply overriding the opacity of the scale widget's rendering. We already have raster caching on the scale transition widgets, enabled by the filterQuality parameter on the transition widget. Unfortunately the Opacity implementation will either cache its child (resulting in double caching in this case), or use a saveLayer (essentially the same thing, but using temporary memory rather than memory that carries forward between frames). There is already an issue (#75697) that has been requesting that the opacity layers forward their opacity values to the children for implementation, but we don't have a solution for that yet. When we do, though, the technique I outline here would work much better than what can be accomplished now. |
Any chances for those golden failures can be fixed recently? |
|
I haven't had time to investigate the source of those problems yet; will do so as soon as I am able. |
|
@flar Do you think we can reland this again? I saw the default enabled |
Reverts #88409
Caused a performance regression, see #88480.
Unfortunately #88409 also caused some unexpected golden image failures on internal tests, i.e. not just failures that were obviously due to the route change animation (see internal Google issue b/197155815)
Fixes #88480