Skip to content

Fixed leak and removed no-shuffle tag in platform_channel_test.dart #88432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gspencergoog merged 2 commits into from
Aug 23, 2021
Merged

Fixed leak and removed no-shuffle tag in platform_channel_test.dart #88432

gspencergoog merged 2 commits into from
Aug 23, 2021

Conversation

@Swiftaxe
Copy link
Contributor

@Swiftaxe Swiftaxe commented Aug 18, 2021

This PR fixed the problem that prevented platform_channel_test.dart being shuffled. Part of #85160.

A couple of tests sets up callbacks through setMethodCallHandler() that gets unresolved and breaks other tests.
This PR clears those callbacks by passing null to setMethodCallHandler.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 18, 2021
@google-cla
Copy link

google-cla bot commented Aug 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 18, 2021
@SigmaAD
Copy link

SigmaAD commented Aug 18, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 18, 2021
@Swiftaxe Swiftaxe marked this pull request as ready for review August 23, 2021 18:49
gspencergoog
gspencergoog approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog gspencergoog merged commit 02bb8a4 into flutter:master Aug 23, 2021
@Swiftaxe Swiftaxe deleted the 85160_platform_channel_test branch August 27, 2021 06:19
@gnprice gnprice mentioned this pull request Mar 30, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Swiftaxe @SigmaAD @gspencergoog