Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 18, 2021

Reverts #82670

This caused a tools test failure. They are not set up to run on presubmit for framework PRs.
Fixes #88393
See also #88395.

@jmagman jmagman requested review from AlexV525 and HansMuller August 18, 2021 00:43
@jmagman jmagman self-assigned this Aug 18, 2021
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 18, 2021
@google-cla google-cla bot added the cla: yes label Aug 18, 2021
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Aug 18, 2021

Merging to green the tree.

@jmagman jmagman merged commit 4053b4b into master Aug 18, 2021
@jmagman jmagman deleted the revert-82670-replace-with-zoom-transition branch August 18, 2021 00:48
blasten pushed a commit to blasten/flutter that referenced this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"flutter error messages include a DevTools link" tool test fails

3 participants