Skip to content

Revert "Refactor iOS integration_test API to support Swift, dynamically add native tests"#88377

Merged
jmagman merged 1 commit into
masterfrom
revert-88013-flat-integration-test-api
Aug 17, 2021
Merged

Revert "Refactor iOS integration_test API to support Swift, dynamically add native tests"#88377
jmagman merged 1 commit into
masterfrom
revert-88013-flat-integration-test-api

Conversation

@zanderso

Copy link
Copy Markdown
Member

Reverts #88013

Failures on CI

@zanderso
zanderso requested a review from jmagman August 17, 2021 21:24
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label Aug 17, 2021
@zanderso

Copy link
Copy Markdown
Member Author

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20complex_layout_scroll_perf_ios__timeline_summary/1920/overview

Maybe this?

ld: '/opt/flutter/xcode/12c33/XCode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/Frameworks/XCTest.framework/XCTest' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. file '/opt/flutter/xcode/12c33/XCode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/Frameworks/XCTest.framework/XCTest' for architecture arm64

@jmagman

jmagman commented Aug 17, 2021

Copy link
Copy Markdown
Member

LGTM, thanks @zanderso

@jmagman

jmagman commented Aug 17, 2021

Copy link
Copy Markdown
Member

Merging to green the build.

@jmagman
jmagman merged commit 463f973 into master Aug 17, 2021
@jmagman
jmagman deleted the revert-88013-flat-integration-test-api branch August 17, 2021 21:54
blasten pushed a commit to blasten/flutter that referenced this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants