-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Make MultiChildRenderObjectWidget and its descendants const #88359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MultiChildRenderObjectWidget and its descendants const #88359
Conversation
396e46c to
de7a34e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected that const can on line 32, but that results in:
error: Evaluation of this constant expression throws an exception. (const_eval_throws_exception at [flutter] test/widgets/list_body_test.dart:49)
de7a34e to
e96c309
Compare
e96c309 to
bba6858
Compare
|
@goderbauer Since the PR has been open for a while, is this waiting for anything from me? (Besides the merge conflict.) |
|
Sorry for the delay. Is the reasoning here that we can remove the check because in an NNBD world |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
For how long will this be the case ?. |
|
Is there any update on this? Having |
|
Done! See #118837 |
|
Thanks ! today is a good day :) |
|
It'll still requires a little more work before it is truly done, but we're on it. |
Relates to dart-lang/sdk#29276
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.