Skip to content

Conversation

@blasten
Copy link

@blasten blasten commented Aug 12, 2021

Migrate a single test to Gradle 7 and use Open JDK 11.

Issue: #87649
Related PR: #87761

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 12, 2021
@google-cla google-cla bot added the cla: yes label Aug 12, 2021
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

task_name: complex_layout_android__compile
dependencies: >-
[
{"dependency": "open_jdk", "version": "11"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to override the cache.

caches: >-
  [
          {"name":"openjdk","path":"java11"},
  ]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i'll send a PR

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • This pull request has changes requested by @CaseyHillers. Please resolve those before re-applying the label.

@blasten blasten requested a review from CaseyHillers August 13, 2021 01:22
@fluttergithubbot fluttergithubbot merged commit 91e0759 into flutter:master Aug 13, 2021
goderbauer added a commit that referenced this pull request Aug 13, 2021
goderbauer added a commit that referenced this pull request Aug 13, 2021
blasten pushed a commit to blasten/flutter that referenced this pull request Aug 19, 2021
blasten pushed a commit to blasten/flutter that referenced this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants