-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Bump to Gradle 7 and use Open JDK 11 #88133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| task_name: complex_layout_android__compile | ||
| dependencies: >- | ||
| [ | ||
| {"dependency": "open_jdk", "version": "11"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also need to override the cache.
caches: >-
[
{"name":"openjdk","path":"java11"},
]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it make sense to cover this in the docs too ? https://github.com/CaseyHillers/cocoon/blob/1f1fa81e2588904908d613111a9d72e784cc6e24/CI_YAML.md#upgrading-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i'll send a PR
|
This pull request is not suitable for automatic merging in its current state.
|
This reverts commit 91e0759.
Migrate a single test to Gradle 7 and use Open JDK 11.
Issue: #87649
Related PR: #87761