-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Update flutter create templates for Xcode 13 #88074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <Scheme | ||
| LastUpgradeVersion = "1020" | ||
| LastUpgradeVersion = "1300" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, what is 1020 and 1300 mean? are these constant codes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the version of Xcode that last checked if anything needed to be updated. The last time we updated this was Xcode 10.2. This change updates to Xcode 13.0.
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! (Post-submit) lgtm!
Get rid of the "Update to recommended settings" warning on new iOS and macOS Flutter projects (shows up on all supported versions of Xcode) by marking
LastUpgradeCheckandobjectVersionas already resolved by Xcode 13.SWIFT_COMPILATION_MODEfromSWIFT_OPTIMIZATION_LEVEL, and rearrange the scheme metadata.Flutter.xcconfigfile to the host module template (it was already referenced, but not in all the necessary places)Unfortunately the "Update to recommended settings" warning is only visible in the Xcode GUI, not from the command line output, so I don't see an easy way to test if it's missing.
Update unit tests, add macOS create test.