Stop using package:stack_trace and Chain.capture #8803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this fails on Windows |
Contributor
Author
|
@goderbauer PTAL at the Windows specific fix. |
tvolkert
reviewed
Mar 15, 2017
Contributor
There was a problem hiding this comment.
/cc @yjbanov who had occasion to change this code to work this way just last week.
Contributor
There was a problem hiding this comment.
Actually, n/m -- he didn't add the Chain.capture(), and this is still semantically the same
tvolkert
reviewed
Mar 15, 2017
Contributor
There was a problem hiding this comment.
There's a slight semantic difference here -- previously, it would use the value of traceStartup that was passed to its constructor if it was unspecified in run(). Now it'll always default to false
Contributor
|
LGTM with 1 comment |
- [x] Don't use package:stack_trace. - [x] Don't use Chain.capture. - [x] Fix an instance of aggressive catching of exceptions Related #8742
yjbanov
reviewed
Mar 15, 2017
Contributor
yjbanov
left a comment
yjbanov
left a comment
There was a problem hiding this comment.
Should we also remove the dependency in pubspec.yaml?
Contributor
|
+1 to this patch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #8742
@tvolkert