Reland "update ScrollMetricsNotification (#87421)" #87818
Conversation
This reverts commit 0f465e5.
flutter-dashboard
bot
added
f: cupertino
|
Some tests failed because of multiple assertions reported. I am surprised that the test did not report an error when it first landing. |
|
7bbcdc239b changed the way the error is reported |
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
It looks like the failing tests reveal a condition that should be added to the changes from 7bbcdc2
If more than one position is attached to the controller, then RawScrollbarState._shouldUpdatePainter should return false. The failing checks appear to be from the gallery integration tests.
@chunhtai do you want to add that here? Or should I add it in a separate change?
|
@Piinks I will add it in this pr |
chunhtai
force-pushed
the
reland-notification
branch
from
828a5c5 to
9fc17cf
Compare
| /// | ||
| /// This should not be mutated directly. [ScrollPosition] objects can be added | ||
| /// and removed using [attach] and [detach]. | ||
| @protected |
There was a problem hiding this comment.
Ooo this is a very exciting change. There are so many work arounds for this that we could clean up. :)
|
one golden failure that is a pretty minor diff and is probably the correct change merging this pr |
3 participants
This reverts commit 0f465e5.
previous pr broke internal tests. The test will be fixed by cl/388794349
blocked on cl/388794349
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.