Skip to content

Adds tooltip to semantics node #87684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Apr 21, 2022
Merged

Adds tooltip to semantics node #87684

fluttergithubbot merged 2 commits into from
Apr 21, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Aug 4, 2021 •
edited
Loading

engine part: flutter/engine#27893

fixes #86577

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 4, 2021
@google-cla google-cla bot added the cla: yes label Aug 4, 2021
@chunhtai chunhtai mentioned this pull request Aug 4, 2021
Merged
8 tasks
@chunhtai chunhtai marked this pull request as ready for review August 10, 2021 21:52
@flutter-dashboard flutter-dashboard bot added the a: tests "flutter test", flutter_test, or one of our tests label Aug 10, 2021
@chunhtai
Copy link
Contributor Author

chunhtai commented Aug 10, 2021

This pr needs engine change to pass the presubmit

@chunhtai chunhtai requested review from blasten and goderbauer August 10, 2021 21:53
goderbauer
goderbauer approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/semantics/semantics.dart Outdated
Copy link
Member

@goderbauer goderbauer Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere we should document that on iOS this is just read out as part of the label (or value?).

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Aug 25, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai
Copy link
Contributor Author

chunhtai commented Aug 25, 2021

google test is failing because the engine change has not rolled into google

@chunhtai
Copy link
Contributor Author

chunhtai commented Aug 25, 2021

needs to wait for the commit to roll in
8fe859f

@chunhtai chunhtai force-pushed the issues/86577 branch 3 times, most recently from f9efadd to 85dd202 Compare August 27, 2021 20:42
@chunhtai
Copy link
Contributor Author

chunhtai commented Sep 8, 2021

This is currently blocked on internal code migration

@chunhtai chunhtai force-pushed the issues/86577 branch 2 times, most recently from fcf22c8 to d41ecae Compare September 27, 2021 21:22
@Hixie
Copy link
Contributor

Hixie commented Dec 15, 2021

What's the status of this PR?

@chunhtai
Copy link
Contributor Author

chunhtai commented Dec 15, 2021

I almost got to it last time and high priority thing piles up. let me close this until i have time to come back to this pr

@chunhtai chunhtai closed this Dec 15, 2021
@chunhtai chunhtai mentioned this pull request Mar 24, 2022
Closed
@chunhtai chunhtai reopened this Apr 13, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 13, 2022

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
f51d11d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
0c499a0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
4f1a476
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
bbb1746
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
551f5a6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
5ef9dd8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
4043e2d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
8b86d79
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
7948326
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
60b0dd7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
38947ae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
8ce514d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
a9306f7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
4a07e72
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
c462e26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
f45060d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
2611b41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
b7d3c4e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
d1cd45d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
236a5fc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
351c8e3
This was referenced Apr 27, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
13c91b8
cyanglaz pushed a commit to flutter/plugins that referenced this pull request Apr 28, 2022
[video_player] Fix XCUITest based on the new tooltip accessibility la…
4b687c9 
…bel (#5426)

The accessibility label for tool tip seems change in one of the recent flutter updates(flutter/flutter#87684), which results failure in this particular XCUITest. This is blocking the flutter to plugins roll.

Fixes: flutter/flutter#102698
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
2ebc7be Adds tooltip to semantics node (flutter/flutter#87684)
5813878
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@chunhtai @egramond
Adds tooltip to semantics node (flutter#87684)
b8f8da3
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@mauricioluz
[video_player] Fix XCUITest based on the new tooltip accessibility la…
29554ad 
…bel (flutter#5426)

The accessibility label for tool tip seems change in one of the recent flutter updates(flutter/flutter#87684), which results failure in this particular XCUITest. This is blocking the flutter to plugins roll.

Fixes: flutter/flutter#102698
ValentinVignal pushed a commit to ValentinVignal/flutter__packages that referenced this pull request Feb 23, 2023
[video_player] Fix XCUITest based on the new tooltip accessibility la…
952e3ff 
…bel (flutter#5426)

The accessibility label for tool tip seems change in one of the recent flutter updates(flutter/flutter#87684), which results failure in this particular XCUITest. This is blocking the flutter to plugins roll.

Fixes: flutter/flutter#102698
zhouyuanbo pushed a commit to zhouyuanbo/video_player_avfoundation_2.4.6 that referenced this pull request Jun 1, 2023
[video_player] Fix XCUITest based on the new tooltip accessibility la…
a37d51c 
…bel (#5426)

The accessibility label for tool tip seems change in one of the recent flutter updates(flutter/flutter#87684), which results failure in this particular XCUITest. This is blocking the flutter to plugins roll.

Fixes: flutter/flutter#102698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[a11y] avoid TYPE_WINDOW_STATE_CHANGED to announce tooltips

5 participants

@chunhtai @fluttergithubbot @Hixie @goderbauer @blasten