Skip to content

Conversation

@jakobr-google
Copy link
Contributor

Changed the default build output directory in the new project template
to build/, instead of android/build/ and android/app/build/.

Updated tools to ask the Gradle scripts what the build directory is,
since this is configurable in the build scripts, and we need to know
where the build output actually is.

Silenced output from 'flutter build aot' when invoked from Gradle, since
the output was confusing in this case.

Fixes #8723
Fixes #8656
Fixes #8138

Changed the default build output directory in the new project template
to build/, instead of android/build/ and android/app/build/.

Updated tools to ask the Gradle scripts what the build directory is,
since this is configurable in the build scripts, and we need to know
where the build output actually is.

Silenced output from 'flutter build aot' when invoked from Gradle, since
the output was confusing in this case.

Fixes flutter#8723
Fixes flutter#8656
Fixes flutter#8138
Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakobr-google jakobr-google merged commit 1457f3d into flutter:master Mar 15, 2017
@jakobr-google jakobr-google deleted the gradlerific branch March 15, 2017 09:53
yjbanov added a commit to yjbanov/flutter that referenced this pull request Mar 15, 2017
Hixie pushed a commit that referenced this pull request Mar 15, 2017
@Hixie
Copy link
Contributor

Hixie commented Mar 15, 2017

This broke the flutter_gallery__start_up flutter lab test.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new gradle build system should put apk in <app>/build directory flutter build clean doesn't work Improve build output when building

4 participants