update ScrollMetricsNotification #87421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: cupertino
8 tasks
Piinks
requested changes
Aug 2, 2021
| // thumb to show immediately when isAlwaysShown is true. A scroll | ||
| // event is required in order to paint the thumb. | ||
| assert(_debugCheckHasValidScrollPosition()); | ||
| scrollController!.position.didUpdateScrollPositionBy(0); |
Contributor
There was a problem hiding this comment.
Removing this hack is nice! 👍
Piinks
reviewed
Aug 2, 2021
| if (widget.isAlwaysShown == true) { | ||
| _maybeTriggerScrollbar(); | ||
| assert(_debugScheduleCheckHasValidScrollPosition()); | ||
| _fadeoutTimer?.cancel(); |
Contributor
There was a problem hiding this comment.
Oh I see, the rest was factored out of the assert. This is a really nice clean up.
Contributor
Piinks
added a commit
that referenced
this pull request
Aug 4, 2021
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
Aug 6, 2021
This reverts commit 0f465e5.
chunhtai
added a commit
that referenced
this pull request
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, notify the first scroll metrics initialize change(null -> non-null)
2,remove the first empty scroll notification request
CC @Piinks @chunhtai