Skip to content

Conversation

@keyonghan
Copy link
Contributor

.ci.yaml Outdated

- name: Linux test_ownership
builder: Linux test_ownership
postsubmit: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, there shouldn't be presubmit only targets. Presubmit only runs the tree of the PR, and not what the merged tree will be.

Also, if we had to mark this as flaky, we'd lose all coverage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the plan to deprecate the postsubmit flag in the long run?

Updated to run both presubmit and postsubmit, and marked it as flaky.
Here is the recipe cl: https://flutter-review.googlesource.com/c/infra/+/16400 to add prod builders. PTAL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a valid point to remove the postsubmit field, but i'm not sure. I need more time to think about it, as there may be some need to do presubmit only \cc @christopherfujino

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't have a strong opinion, but it would be nice to have the option, i can imagine we might in the future have need for a pre-submit only test. off the top of my head, i can't think of an example, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this more, and there is a case where you want postsubmit: false.

I'd like to add an FYI check for infra that validates ci.yaml changes won't get the tree into a bad state. If someone adds a new target without bringup: true, it would block the PR. However, they could override it (in the case of renames).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants