-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Enable test ownership validation test in pre-submit #87310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable test ownership validation test in pre-submit #87310
Conversation
.ci.yaml
Outdated
|
|
||
| - name: Linux test_ownership | ||
| builder: Linux test_ownership | ||
| postsubmit: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, there shouldn't be presubmit only targets. Presubmit only runs the tree of the PR, and not what the merged tree will be.
Also, if we had to mark this as flaky, we'd lose all coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the plan to deprecate the postsubmit flag in the long run?
Updated to run both presubmit and postsubmit, and marked it as flaky.
Here is the recipe cl: https://flutter-review.googlesource.com/c/infra/+/16400 to add prod builders. PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a valid point to remove the postsubmit field, but i'm not sure. I need more time to think about it, as there may be some need to do presubmit only \cc @christopherfujino
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't have a strong opinion, but it would be nice to have the option, i can imagine we might in the future have need for a pre-submit only test. off the top of my head, i can't think of an example, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this more, and there is a case where you want postsubmit: false.
I'd like to add an FYI check for infra that validates ci.yaml changes won't get the tree into a bad state. If someone adds a new target without bringup: true, it would block the PR. However, they could override it (in the case of renames).
#87144