Exclude arm64 from iOS app archs if unsupported by plugins #87244
Conversation
jmagman
added
platform-ios
|
Will fix #87201 as well |
jmagman
added
waiting for tree to go green
and removed
waiting for tree to go green
labels
|
Ugh, this isn't going to work, the plugin build settings from the podspec are generated into an |
|
I rewrote this to call |
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with typo fix
packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart
Outdated
Show resolved
Hide resolved
| '-project', | ||
| podXcodeProject.path, | ||
| '-showBuildSettings', | ||
| ], |
There was a problem hiding this comment.
Optional: you've got a lot of copies of this very long command; it might be helpful to have a little utility method that takes output (and an optional exit code) and builds the FakeCommand, to make the tests a bit less verbose and easier to update if the argument list needs to be changed slightly in the future.
There was a problem hiding this comment.
I put the hw.optional.arm64: 1 command into a constant which cleaned it up a bit. Generally I prefer seeing the "important" command inline in the test rather than trying to keep tests DRY. That's just preference though. Fortunately the test will start failing if the arguments ever change, so it's usually really easy to update even in a few places.
|
The tree is green, not sure why the |
3 participants
If any plugins declare they do not support arm64 simulators, also mark the entire iOS app as not supporting arm64 simulators to avoid compilation failures. This will cause the app to run in x64 Rosetta translation mode.
Parse the output of
Plugins will be expected to add this to their podspec:
google_maps_flutter: #87242
google_sign_in: #87243
Fixes #85713