Add test ownership for firebase tests and docs tests #87145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
approved these changes
Jul 28, 2021
keyonghan
changed the title
keyonghan
commented
Jul 28, 2021
Comment on lines
+192
to
+194
| # Linux docs | ||
| # Linux docs_test | ||
| # Linux docs_publish |
Contributor
Author
There was a problem hiding this comment.
Linux docs and Linux docs_publish use same test file as Linux docs_test, so the test owner should be the same.
Please let me know if this is not the case.
/cc @HansMuller
Contributor
There was a problem hiding this comment.
#87135 - We're consolidating these targets. Do we need to also update the test owners file, or will the bot handle missing targets?
Contributor
Author
There was a problem hiding this comment.
When you update the .ci.yaml, please update the test owners file here as well.
From the linked issue and cl, you can remove the Linux docs entry here by then.
To summarize: this test owner file needs to sync with .ci.yaml.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs adds test ownership for the missing tests: firebase tests and docs tests.
This is part of #87144